Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .form-text references #30397

Closed
wants to merge 5 commits into from
Closed

Remove .form-text references #30397

wants to merge 5 commits into from

Conversation

zalog
Copy link
Contributor

@zalog zalog commented Mar 15, 2020 •
edited
Loading

This PR removes all related references .form-text from css and docs.

deploy-preview

Thanks for your time.

@zalog zalog requested a review from a team as a code owner March 15, 2020 16:54
@zalog zalog changed the title Removes .form-text Removes .form-text references Mar 15, 2020
@zalog
Copy link
Contributor Author

zalog commented Mar 16, 2020

I made a rebase.

@ysds
Copy link
Member

ysds commented Mar 16, 2020

I would respect @mdo's thought, but I personally prefer the default margin of the feedback messages, because the margins are often consistent through an app. If remove this margin, please keep the variable ($form-feedback-margin-top: null) for users can set a default value.

@zalog
Copy link
Contributor Author

zalog commented Mar 16, 2020

Tnks @ysds.

@XhmikosR XhmikosR requested a review from mdo March 17, 2020 09:40
@zalog zalog force-pushed the zalog-form-text branch 4 times, most recently from 81d8e65 to af1c8ab Compare March 22, 2020 08:01
@XhmikosR XhmikosR changed the title Removes .form-text references Remove .form-text references Mar 24, 2020
@zalog
Copy link
Contributor Author

zalog commented Mar 24, 2020

Bu! Just rebased this and solve all conflicts.

@MartijnCuppens
Copy link
Member

Not sure about this, see #30477. Nevertheless, we need to have a look at cleaning things up indeed.

@zalog zalog force-pushed the zalog-form-text branch 4 times, most recently from 088664b to 9c6bc92 Compare April 1, 2020 13:46
@zalog zalog force-pushed the zalog-form-text branch 4 times, most recently from 22a263f to 243be5f Compare April 7, 2020 06:18
@zalog
fix: replaces .text-small with .small
4f68fbe 
Fixes using a non existing class.
@MartijnCuppens MartijnCuppens mentioned this pull request Apr 11, 2020
Closed
@MartijnCuppens
Copy link
Member

Gonna close this, see #30477 (comment)

@zalog zalog deleted the zalog-form-text branch April 15, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zalog @ysds @MartijnCuppens